-
Notifications
You must be signed in to change notification settings - Fork 123
CSPL-3768 Adding inputs to Graviton pipelines and tests #1521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSPL-3768 Adding inputs to Graviton pipelines and tests #1521
Conversation
Pull Request Test Coverage Report for Build 15583052216Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 15611458045Details
💛 - Coveralls |
// Upload V1 apps to S3 for Monitoring Console | ||
oldImage := "Refer to RELATED_SPLUNK_IMAGE_ENTERPRISE" | ||
newImage := "splunk/splunk:latest" | ||
newImage := testcaseEnvInst.GetSplunkImage() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to change this line? These tests are testing image upgrades, what if RELATED_SPLUNK_IMAGE_ENTERPRISE
and testcaseEnvInst.GetSplunkImage()
are the same value? I guess we could run into the same thing with the current implementation if RELATED_SPLUNK_IMAGE_ENTERPRISE
is the same as splunk/splunk:latest
so maybe it is not an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
It adds inputs to Github actions for Graviton builds not to create branches with temporary image changes or replace secret values temporarily.
Key Changes
Testing and Verification
Tested by automation. Neither manual tests nor new automated tests required.
Integ tests run: #1522
RHEL smoke run: https://github.com/splunk/splunk-operator/actions/runs/15587504408
RHEL integ run: https://github.com/splunk/splunk-operator/actions/runs/15587498696
Related Issues
Jira: https://splunk.atlassian.net/browse/CSPL-3756
PR Checklist