Skip to content

Conversation

kasiakoziol
Copy link
Collaborator

@kasiakoziol kasiakoziol commented Jun 11, 2025

Description

It adds inputs to Github actions for Graviton builds not to create branches with temporary image changes or replace secret values temporarily.

Key Changes

  • Introducing Github inputs.
  • Enhancing tests to use Github inputs.

Testing and Verification

Tested by automation. Neither manual tests nor new automated tests required.
Integ tests run: #1522
RHEL smoke run: https://github.com/splunk/splunk-operator/actions/runs/15587504408
RHEL integ run: https://github.com/splunk/splunk-operator/actions/runs/15587498696

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-3756

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 15583052216

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.654%

Totals Coverage Status
Change from base Build 15559007893: 0.0%
Covered Lines: 10596
Relevant Lines: 12228

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2025

Pull Request Test Coverage Report for Build 15611458045

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 86.645%

Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/afwscheduler.go 1 92.96%
Totals Coverage Status
Change from base Build 15559007893: -0.009%
Covered Lines: 10595
Relevant Lines: 12228

💛 - Coveralls

// Upload V1 apps to S3 for Monitoring Console
oldImage := "Refer to RELATED_SPLUNK_IMAGE_ENTERPRISE"
newImage := "splunk/splunk:latest"
newImage := testcaseEnvInst.GetSplunkImage()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to change this line? These tests are testing image upgrades, what if RELATED_SPLUNK_IMAGE_ENTERPRISE and testcaseEnvInst.GetSplunkImage() are the same value? I guess we could run into the same thing with the current implementation if RELATED_SPLUNK_IMAGE_ENTERPRISE is the same as splunk/splunk:latest so maybe it is not an issue.

@kasiakoziol kasiakoziol marked this pull request as ready for review June 12, 2025 14:08
Copy link
Collaborator

@patrykw-splunk patrykw-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasiakoziol kasiakoziol merged commit 384ed59 into develop Jun 13, 2025
27 checks passed
@kasiakoziol kasiakoziol deleted the CSPL-3768-graviton-pipelines-enhancements branch June 13, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants