CSPL-521: Added more delay and checks for MC pod to be ready #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdhanoya-splunk
force-pushed
the
mctestdelay
branch
from
26e6663 to
3338a01
Compare
|
|
||
| // defaultTestTimeout is the max timeout in seconds before async test failed. | ||
| defaultTestTimeout = 900 | ||
| defaultTestTimeout = 1500 |
There was a problem hiding this comment.
What is the reason for increasing this timeout?
There was a problem hiding this comment.
MC deployment is taking longer hence 1500 seconds to make tests more stable. Also this is worst case scenario ideally the test will be spending around ~600 seconds in this stage.
pdhanoya-splunk
requested review from
akondur,
kashok-splunk,
sgontla and
smohan-splunk
akondur
approved these changes
Oct 26, 2020
kashok-splunk
approved these changes
Oct 26, 2020
gaurav-splunk
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made following changes to address flakiness related to MC test.