CSPL-4024: Enchance IDXC upgrade error message. #1594
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18274889429Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 18187142485Details
💛 - Coveralls |
kasiakoziol
reviewed
Oct 2, 2025
pkg/splunk/enterprise/upgrade.go
Outdated
|
|
||
| // check if an image upgrade is happening and whether CM has finished updating yet, return false to stop | ||
| // further reconcile operations on custom resource until CM is ready | ||
| if clusterManager.Status.Phase != enterpriseApi.PhaseReady || cmImage != spec.Image { |
There was a problem hiding this comment.
Outside if is not needed (if clusterManager.Status.Phase != enterpriseApi.PhaseReady || cmImage != spec.Image) if you divide it into separate ifs
kasiakoziol
approved these changes
Oct 2, 2025
pkg/splunk/enterprise/upgrade.go
Outdated
| } | ||
| goto IndexerCluster | ||
| } | ||
| goto IndexerCluster |
There was a problem hiding this comment.
I guess it doesn't change the logic at all, but is there a reason this line was moved outside of the above code block/braces?
rlieberman-splunk
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist