bugfix/CSPL-466: If in IndexerCluster spec, replicas < RF(which is configured on ClusterMaster), then set replicas=RF. #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigured on ClusterMaster), then set replicas=RF.
gaurav-splunk
requested review from
akondur,
kashok-splunk,
sgontla and
smohan-splunk
gaurav-splunk
commented
Oct 26, 2020
akondur
requested changes
Oct 26, 2020
|
Can we update the documentation as part of this PR to indicate the Operator's corrective measures when replicas<RF? |
akondur
approved these changes
Oct 27, 2020
smohan-splunk
approved these changes
Oct 29, 2020
akondur
reviewed
Oct 30, 2020
sgontla
approved these changes
Oct 30, 2020
kashok-splunk
approved these changes
Oct 30, 2020
akondur
approved these changes
Oct 30, 2020
gaurav-splunk
commented
Nov 6, 2020
| // Negative testing with non-integer version | ||
| for testVersion := 0; testVersion < 10; testVersion++ { | ||
| testSecretName = splcommon.GetVersionedSecretName(versionedSecretIdentifier, string('A'-1+testVersion)) | ||
| testSecretName = splcommon.GetVersionedSecretName(versionedSecretIdentifier, string(rune('A'-1+testVersion))) |
There was a problem hiding this comment.
Had to use rune to fix a compilation error if using go version >=1.15. This was the error when we ran make test -
pkg/splunk/util/secrets_test.go:431:80: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
akondur
approved these changes
Nov 9, 2020
smohan-splunk
approved these changes
Nov 9, 2020
sgontla
approved these changes
Nov 9, 2020
kashok-splunk
approved these changes
Nov 9, 2020
| } | ||
|
|
||
| if mgr.cr.Spec.Replicas < replicationFactor { | ||
| mgr.log.Info("Changing number of replicas as it is less than RF number of peers", "replicas", mgr.cr.Spec.Replicas) |
There was a problem hiding this comment.
super nit: Maybe can change the logging to something like "Increasing number of indexer replicas to match RF number of peers" or something similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In case if IndexerCluster spec has replicas < replication_factor or site_replication_factor as set on ClusterMaster, then IndexerCluster goes in the reconcilation loop since CM is never in Ready state. And the only way to scale indexer cluster is using kubectl scale statefulset .....
Solution
Set replicas = RF if it is less than RF.