CSPL-498 Explicit removal of owner ref from MC statefulset when deleting CR #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kashok-splunk
commented
Nov 6, 2020
kashok-splunk
commented
- Delete CR as the owner of MC statefulset when deleting CR
sgontla
reviewed
Nov 6, 2020
Comment on lines
+69
to
+76
| namespacedName := types.NamespacedName{Namespace: cr.GetNamespace(), Name: GetSplunkStatefulsetName(SplunkMonitoringConsole, cr.GetNamespace())} | ||
| if cr.GetObjectMeta().GetDeletionTimestamp() != nil { | ||
| addNewURLs = false | ||
| //explicit removal of owners for MC | ||
| _, err = splctrl.RemoveStatefulSetOwnerRef(client, cr, namespacedName) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Just thinking this, Assuming this change is to have the MC running even if the last CR is deleted(?), then we can avoid setting the owner reference in the first place unless the CRs are really interested in the MC STS state changes(?). If so, I guess, we don't need any of these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.