Skip to content

Conversation

sgontla
Copy link
Contributor

@sgontla sgontla commented Nov 12, 2020

UT Code coverage for Smartstore/Indexmanagement area of code

@sgontla sgontla requested review from gaurav-splunk, akondur, kashok-splunk and smohan-splunk and removed request for akondur November 12, 2020 23:02
Copy link
Collaborator

@akondur akondur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgontla All the comments are wrt a single change i.e when checking for an err, being deterministic vs checking err == nil. Looks good otherwise.

@sgontla sgontla force-pushed the smartstore_test_coverage branch from d8018c7 to 4efcf23 Compare November 17, 2020 23:09
@smohan-splunk smohan-splunk merged commit e64506a into develop Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants