Skip to content

Smoke test to verify service account attaches to standalone. #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

Smoke test to verify service account attaches to standalone. #238

merged 1 commit into from
Jan 27, 2021

Conversation

pdhanoya-splunk
Copy link
Contributor

  • Smoke test to verify service account attaches to standalone.
  • Added new role needed for service account
  • Added util to get service role name from pod
  • Added verification util to compare serviceAccount on Pod to expected serviceAccount

@pdhanoya-splunk pdhanoya-splunk force-pushed the test_service_account branch 2 times, most recently from 7cd4302 to 6023356 Compare January 22, 2021 22:20
akondur
akondur approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@akondur akondur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

test/testenv/deployment.go Outdated

// DeployStandalonewithGivenSpec deploys a standalone with given spec
func (d *Deployment) DeployStandalonewithGivenSpec(name string, spec enterprisev1.StandaloneSpec) (*enterprisev1.Standalone, error) {

Copy link
Collaborator

@akondur akondur Jan 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Is this newline necessary at the start of every function? Is there a reason why we have this?

@smohan-splunk smohan-splunk merged commit a57a0a9 into develop Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akondur akondur akondur approved these changes

@kumarajeet kumarajeet Awaiting requested review from kumarajeet

+5 more reviewers

@jambrosiano jambrosiano jambrosiano approved these changes

@jryb jryb jryb approved these changes

@kashok-splunk kashok-splunk kashok-splunk approved these changes

@smohan-splunk smohan-splunk smohan-splunk approved these changes

@vebken-splunk vebken-splunk vebken-splunk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pdhanoya-splunk @jambrosiano @jryb @kashok-splunk @smohan-splunk @akondur @vebken-splunk @pdhanoyasplunk