CSPL-540: Added utilities and test for s3 indexes #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pdhanoya-splunk
commented
Jan 26, 2021
pdhanoya-splunk
commented
- Added utilities need for S3 Index test cases
- Created a new test suite for Index Management
- Created S3 utilities to get object from S3 and verify object exists on S3
pdhanoya-splunk
requested review from
jambrosiano,
sgontla,
akondur and
smohan-splunk
pdhanoya-splunk
force-pushed
the
CSPL-540-s3-secret-object
branch
6 times, most recently
from
2b504f8 to
145c69e
Compare
jryb
approved these changes
Jan 26, 2021
| if err != nil { | ||
| logf.Log.Error(err, "Failed to create s3 session") | ||
| } | ||
| svc := s3.New(session.Must(sess, err)) |
There was a problem hiding this comment.
Nice! No issue here just wanted to tag @kumarajeet @vebken-splunk since this is what we could use for App framework.
|
This PR lowered our coverage in coveralls?!?!? Do we count the code in |
pdhanoya-splunk
force-pushed
the
CSPL-540-s3-secret-object
branch
from
145c69e to
6456b5a
Compare
smohan-splunk
approved these changes
Jan 27, 2021
| } | ||
| }) | ||
|
|
||
| Context("Confiugre indexes on standlaone deployment using CR Spec", func() { |
| // RollHotBuckets roll hot buckets in cluster | ||
| func RollHotBuckets(deployment *Deployment) bool { | ||
| podName := fmt.Sprintf("splunk-%s-cluster-master-0", deployment.GetName()) | ||
| stdin := "/opt/splunk/bin/splunk rolling-restart cluster-peers -auth admin:$(cat /mnt/splunk-secrets/password)" |
There was a problem hiding this comment.
Could we just use the roll-hot-buckets command instead of rolling-restart?
There was a problem hiding this comment.
I will do that as part of next PR. I just added this util but its not being used. I am using roll-hot-buckets on standalone which is part of this PR and will follow similar pattern for Indexer cluster.
pdhanoya-splunk
force-pushed
the
CSPL-540-s3-secret-object
branch
from
6456b5a to
dc1b255
Compare
pdhanoya-splunk
force-pushed
the
CSPL-540-s3-secret-object
branch
from
dc1b255 to
f7bc91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.