CSPL-763 - App framework related changes #245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohan-splunk
requested review from
gaurav-splunk,
sgontla,
akondur,
vebken-splunk and
kashok-splunk
and removed request for
sgontla
|
|
||
| func TestValidateApplicationFrameworkSpec(t *testing.T) { | ||
| var err error | ||
| // Valid app framework config with proper inputs |
There was a problem hiding this comment.
Can we add a Positive test case too?
There was a problem hiding this comment.
Sure, let me check.
There was a problem hiding this comment.
Positive check was also added.
akondur
reviewed
Feb 2, 2021
kashok-splunk
approved these changes
Feb 4, 2021
akondur
approved these changes
Feb 4, 2021
akondur
reviewed
Feb 4, 2021
1) Log only if apps framework feature flag is true 2) Use scoped logging
| description: App Package Remote Store Endpoint | ||
| type: string | ||
| s3PollInterval: | ||
| description: App Package Remote Store Polling interval |
There was a problem hiding this comment.
We should probably add the units and default value here so users know what they are configuring.
Also I noticed that it looks like the other code is written with seconds in mind, from our earlier discussion did we want to go with minutes instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is for a story as part of AppFramework Operator-Setup. This story provides configuration section to pass the App Framework related parameters.
It is applicable to following CRs:
Standalone, ClusterMaster, SearchHeadCluster and LicenseMaster
By default, this feature is disabled unless we explicitly enable it by adding following under "applications" section
featureEnabled: TRUECurrently unit tests are present for the configuration values for :