CSPL-841 Upgrade aws-sdk-go version to v1.34.1 or later #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vebken-splunk
requested review from
smohan-splunk,
kumarajeet,
mgaldino-splunk and
akondur
go.mod
Outdated
|
|
||
| require ( | ||
| github.com/aws/aws-sdk-go v1.17.7 | ||
| github.com/aws/aws-sdk-go v1.34.1 |
There was a problem hiding this comment.
I see this particular version v1.34.1 of library was last released in 2020-08-10, while the latest version is v1.37.21 (released today!). What would some of the primary reasons be to stick to an older version?
There was a problem hiding this comment.
I don't have any objections going to the newest version, I was mainly worried about any compatibility issues as we experienced with the newer versions of some other libraries (caused build failures). I have pushed a commit to update to v1.37.21 and will check the CI results.
akondur
approved these changes
Mar 2, 2021
smohan-splunk
approved these changes
Mar 2, 2021
A Whitesource scan of the operator branch revealed it is vulnerable to CVE-2020-8911 and CVE-2020-8912 CVE-2020-8911 is fixed by upgrading the aws-sdk-go library to v1.34.1 or later. CVE-2020-8912 is fixed by upgrading the aws-sdk-go library to v1.28.3 or later.
vebken-splunk
force-pushed
the
bugfix/CSPL-841
branch
from
31740c1 to
145eef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Whitesource scan of the operator branch revealed it is vulnerable to CVE-2020-8911 and CVE-2020-8912
CVE-2020-8911 is fixed by upgrading the aws-sdk-go library to v1.34.1 or later.
CVE-2020-8912 is fixed by upgrading the aws-sdk-go library to v1.28.3 or later.