CSPL-887: Documentation review #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangeLog.md - No changes. - Inbound links: Readme.md Contributing.md - No changes. - Inbound links: None. Add from Readme.md CustomResources.md - No changes. OpenShift.md - No changes. It's a bit thin, but maybe there's no other detail required? - Inbound links: Readme.md Faq.md - Remove. The only viable content remains is a quip about why HELM wasn't used. README.md - Significant changes Install.md - Cleanup Images.md - Cleanup StorageClass.md - Cleanup Ingress.md - Adding numbers to procedures. SmartStore.md - No changes. PasswordManagement.md - No changes. Examples.md - No changes. MultisiteExamples.md - No changes.
smohan-splunk
approved these changes
Mar 11, 2021
|
Seems like there are some merge conflicts to resolve, I'm assuming they are mostly relating to removal of Spark from the docs. |
|
A general nitpick question I have reviewing the docs, when we are using "operator" as shorthand for "Splunk Operator" rather than the Kubernetes operator pattern, should it be capitalized? |
|
For all yaml examples, we should update the apiVersion to v1 per #274 |
mgaldino-splunk
force-pushed
the
CSPL-887
branch
from
7a7e1dd to
b1e2090
Compare
mgaldino-splunk
approved these changes
Mar 17, 2021
vebken-splunk
suggested changes
Mar 17, 2021
vebken-splunk
approved these changes
Mar 17, 2021
akondur
approved these changes
Mar 17, 2021
| If you retagged the Splunk Operator container image as part of pushing | ||
| it to a private registry, you will need to edit the image parameter in the | ||
| `splunk-operator` deployment to reference the appropriate image name. | ||
| If you plan to retag the container images as part of pushing it to a private registry, edit the image parameter in the `splunk-operator` deployment to reference the appropriate image name. |
There was a problem hiding this comment.
Is there any reason why we are removing the advisory note depicting the size of the Splunk Enterprise container image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog.md - No changes. - Inbound links: Readme.md
Contributing.md - No changes. - Inbound links: None. Add from Readme.md
CustomResources.md - No changes.
OpenShift.md - No changes. It's a bit thin, but maybe there's no other detail required? - Inbound links: Readme.md
Faq.md - Remove. The only viable content remains is a quip about why HELM wasn't used.
README.md - Significant changes
Install.md - Cleanup
Images.md - Cleanup
StorageClass.md - Cleanup
Ingress.md - Adding numbers to procedures.
SmartStore.md - No changes.
PasswordManagement.md - No changes.
Examples.md - No changes.
MultisiteExamples.md - No changes.