Initial PR for CSPL-892 - system resources documentation #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end unit test cases
1) Log only if apps framework feature flag is true 2) Use scoped logging
it was not given. Enhanced the CRDs descriptions for apps framework for better understanding of this interface.
…orage IO]. Contains CPU/Mem guidelines. Storage I/O TBD.
akondur
reviewed
Mar 18, 2021
| type: array | ||
| type: object | ||
| type: object | ||
| appFrameworkRef: |
There was a problem hiding this comment.
Seems like we have appFramework changes here as well?
|
As this PR got some commits from appframework branch, so I am closing (deleting it). Will open a clean PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for CPU/Mem added.
Storage I/O coming next.