CSPL-909: Add test cases to verify changes to CR spec are applied to clustered environments #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jambrosiano
changed the title
jambrosiano
requested review from
smohan-splunk,
pdhanoya-splunk,
tpereirasplunk,
kumarajeet,
akondur,
vebken-splunk,
kashok-splunk,
sgontla,
mgaldino-splunk,
jryb and
gaurav-splunk
akondur
approved these changes
Mar 22, 2021
kashok-splunk
approved these changes
Mar 22, 2021
mgaldino-splunk
approved these changes
Mar 22, 2021
tpereirasplunk
approved these changes
Mar 23, 2021
smohan-splunk
approved these changes
Mar 23, 2021
| testenv.VerifyIndexerClusterPhase(deployment, testenvInstance, splcommon.PhaseUpdating, idxcName) | ||
|
|
||
| // Verify Indexers go to ready state | ||
| testenv.VerifyIndexerClusterPhase(deployment, testenvInstance, splcommon.PhaseReady, idxcName) |
There was a problem hiding this comment.
Use testenv.SingleSiteIndexersReady(deployment, testenvInstance) instead.
Comment on lines
241
to
275
| // Verify CPU limits on Search Heads before updating the CR | ||
| SearchHeadPodName := fmt.Sprintf(testenv.SearchHeadPod, deployment.GetName(), 0) | ||
| testenv.VerifyCPULimits(deployment, testenvInstance.GetName(), SearchHeadPodName, defaultCPULimits) | ||
| SearchHeadPodName = fmt.Sprintf(testenv.SearchHeadPod, deployment.GetName(), 1) | ||
| testenv.VerifyCPULimits(deployment, testenvInstance.GetName(), SearchHeadPodName, defaultCPULimits) | ||
| SearchHeadPodName = fmt.Sprintf(testenv.SearchHeadPod, deployment.GetName(), 2) | ||
| testenv.VerifyCPULimits(deployment, testenvInstance.GetName(), SearchHeadPodName, defaultCPULimits) | ||
|
|
||
| // Change CPU limits to trigger CR update | ||
| shc := &enterprisev1.SearchHeadCluster{} | ||
| instanceName := fmt.Sprintf("%s-shc", deployment.GetName()) | ||
| err = deployment.GetInstance(instanceName, shc) | ||
| if err != nil { | ||
| testenvInstance.Log.Error(err, "Unable to fetch Search Head Cluster deployment") | ||
| } | ||
|
|
||
| shc.Spec.Resources.Limits = corev1.ResourceList{ | ||
| "cpu": resource.MustParse(newCPULimits), | ||
| } | ||
| err = deployment.UpdateCR(shc) | ||
| Expect(err).To(Succeed(), "Unable to deploy Search Head Cluster with updated CR") | ||
|
|
||
| // Verify Search Head Cluster is updating | ||
| testenv.VerifySearchHeadClusterPhase(deployment, testenvInstance, splcommon.PhaseUpdating) | ||
|
|
||
| // Verify Search Head go to ready state | ||
| testenv.SearchHeadClusterReady(deployment, testenvInstance) | ||
|
|
||
| // Verify CPU limits after updating the CR | ||
| SearchHeadPodName = fmt.Sprintf(testenv.SearchHeadPod, deployment.GetName(), 0) | ||
| testenv.VerifyCPULimits(deployment, testenvInstance.GetName(), SearchHeadPodName, newCPULimits) | ||
| SearchHeadPodName = fmt.Sprintf(testenv.SearchHeadPod, deployment.GetName(), 1) | ||
| testenv.VerifyCPULimits(deployment, testenvInstance.GetName(), SearchHeadPodName, newCPULimits) | ||
| SearchHeadPodName = fmt.Sprintf(testenv.SearchHeadPod, deployment.GetName(), 2) | ||
| testenv.VerifyCPULimits(deployment, testenvInstance.GetName(), SearchHeadPodName, newCPULimits) |
There was a problem hiding this comment.
Do not need to repeat this here as SHC update is already covered in C3 deployment. This is just to ensure test cases get executed in resonable time.
| }) | ||
| }) | ||
|
|
||
| Context("Multisite cluster deployment (M13 - Multisite indexer cluster, Search head cluster)", func() { |
There was a problem hiding this comment.
Change deployment type to M4.
pdhanoya-splunk
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to verify changes to CR spec are applied to the pod, for Indexer and SH clusters environments
SVA Covered:
Test Scenario:
Test Run