-
Notifications
You must be signed in to change notification settings - Fork 124
CSPL-834 Refine Ingress Documentation #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e9a9c5d
CSPL-834 Refine Ingress Documentation
vebken-splunk d6e6a36
Merge branch 'develop' into bugfix/CSPL-834
smohan-splunk 791f0bc
Merge branch 'develop' into bugfix/CSPL-834
smohan-splunk 334e8d8
address review comments
vebken-splunk c33ab86
Merge branch 'bugfix/CSPL-834' of github.com:splunk/splunk-operator i…
vebken-splunk f39f1ac
CSPL-834 Refine Ingress Documentation
vebken-splunk cf1fb23
address review comments
vebken-splunk 043128d
CSPL-780 Deployer PVCs Not Deleted
vebken-splunk 8ff9f0f
review comments
vebken-splunk c36dcec
Merge branch 'bugfix/CSPL-834' of github.com:splunk/splunk-operator i…
vebken-splunk 80a528e
Merge branch 'develop' into bugfix/CSPL-834
smohan-splunk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have updated the heading to include HEC, but the sub-points under the topic have no examples for HEC?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the "Multiple Hosts Configuration" sub-point we reference HEC,
perhaps I could update that sub point heading to Multiple Hosts and HEC Configuration? Or perhaps we could include a solely HEC example with a standalone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, at least an update to the existing Heading will be good!