CSPL-1027: Utility to download or upload file to s3 #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpereirasplunk
requested review from
sgontla,
vebken-splunk,
kashok-splunk,
gaurav-splunk,
jryb,
pdhanoya-splunk,
akondur and
jambrosiano
jryb
reviewed
May 12, 2021
jryb
force-pushed
the
feature-appframework
branch
from
73246a5 to
eab5cfc
Compare
tpereirasplunk
force-pushed
the
CSPL-1027
branch
2 times, most recently
from
1bc293b to
e96fbeb
Compare
smohan-splunk
approved these changes
May 13, 2021
|
Could you squash all these commits into one? It should cancel out to just your changes. Other than that looks good. |
jryb
approved these changes
May 14, 2021
kashok-splunk
approved these changes
May 14, 2021
jambrosiano
approved these changes
May 15, 2021
tpereirasplunk
force-pushed
the
CSPL-1027
branch
5 times, most recently
from
265d360 to
e849af9
Compare
pdhanoya-splunk
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created utility to create a s3 session
Updated Utility to be able to download from S3
** Utility can now be used to download any generic file
Created Utility to be able to upload file to S3
Created Utility to delete file on S3