CSPL-767: Operator trigger Instance pod to download app package from S3 #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sgontla
commented
Jun 8, 2021
sgontla
commented
- Added new configMap to update the latest apps status to the pod locations
sgontla
requested review from
smohan-splunk,
gaurav-splunk,
jryb and
kashok-splunk
and removed request for
smohan-splunk and
gaurav-splunk
jryb
reviewed
Jun 8, 2021
sgontla
force-pushed
the
feature/CSPL-767
branch
from
4ba82b6 to
268c54a
Compare
sgontla
force-pushed
the
feature/CSPL-767
branch
4 times, most recently
from
5051b47 to
eed23fa
Compare
gaurav-splunk
approved these changes
Jun 11, 2021
kashok-splunk
approved these changes
Jun 11, 2021
smohan-splunk
approved these changes
Jun 11, 2021
| returnedCM := PrepareConfigMap(configMapName, namespace, dataMap) | ||
|
|
||
| if !reflect.DeepEqual(expectedCm, returnedCM) { | ||
| t.Errorf("configMap preperation failed") |
|
|
||
| // ApplyAppListingConfigMap creates the configMap with two entries: | ||
| // (1) app-list-local.yaml | ||
| // (2) app-list-cluster.yaml |
There was a problem hiding this comment.
Update comment to clarify that the config map will be used by ansible to install apps
pkg/splunk/enterprise/util.go
Outdated
|
|
||
| // Apply the configMap with a fresh token | ||
| SplunkOperatorAppConfigMap = prepareSplunkSmartstoreConfigMap(cr.GetName(), cr.GetNamespace(), crKind, mapSplunkConfDetails) | ||
| SplunkOperatorAppConfigMap := splctrl.PrepareConfigMap(configMapName, cr.GetNamespace(), mapSplunkConfDetails) |
There was a problem hiding this comment.
Duplicate SplunkOperatorAppConfigMap to be removed
|
|
||
| // check if the apps need to be downloaded from remote storage | ||
| // ToDo: sgontla: Once after we have the flow, move the following logic into a seperate function(Note:- all errors should not cause a return in that function) | ||
| if cr.Spec.CommonSplunkSpec.Mock != true && !reflect.DeepEqual(cr.Status.AppContext.AppFrameworkConfig, cr.Spec.AppFrameworkConfig) { |
There was a problem hiding this comment.
Not introduced as part of this PR, but do we need this Mock check here?
There was a problem hiding this comment.
I think we need this clean-up. I Will add a ToDo note for now.
- Added new configMap to update the latest apps status to the pod locations
sgontla
force-pushed
the
feature/CSPL-767
branch
from
eed23fa to
1977e8c
Compare
jryb
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.