CSPL-1050 Separate CRD for MC #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kashok-splunk
commented
Jun 9, 2021
kashok-splunk
commented
- Separate CRD for MC
- MC configmap creation if cm doesn't exists
- Owner ref for the mc cm
kashok-splunk
commented
Jun 9, 2021
sgontla
reviewed
Jun 9, 2021
sgontla
approved these changes
Jun 11, 2021
smohan-splunk
approved these changes
Jun 11, 2021
|
Need to improve coverage for above cases, as discussed with @gaurav-splunk will work on the coverage in coming PRs |
gaurav-splunk
approved these changes
Jun 11, 2021
akondur
approved these changes
Jun 11, 2021
| Selector string `json:"selector"` | ||
|
|
||
| // Bundle push status tracker | ||
| BundlePushTracker BundlePushInfo `json:"bundlePushInfo"` |
There was a problem hiding this comment.
Do we need this field for MC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.