Skip to content

Conversation

mikedickey
Copy link
Contributor

Updated "make generate" so that it only applies to CRDs YAML files and golang code that is autogenerated from pkg/api source code

Moved YAML install file generate to the build/package.sh script. This can now be used to generate a release- directory with all the relevant files for a new release of Splunk Operator.

Updated "make generate" so that it only applies to CRDs YAML files
and golang code that is autogenerated from pkg/api source code

Moved YAML install file generate to the build/package.sh script.
This can now be used to generate a release-<VERSION> directory
with all the relevant files for a new release of Splunk Operator.
Copy link
Contributor

@kelvinatsplunk kelvinatsplunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kelvinatsplunk
Copy link
Contributor

I think we can remove the role_binding.yaml file too ?

@mikedickey
Copy link
Contributor Author

I think we can remove the role_binding.yaml file too ?

Yes, it is removed by this PR

@mikedickey mikedickey merged commit a5a2560 into master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants