Skip to content

cspl-1139: Make Probe timers dynamic #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2021
Merged

cspl-1139: Make Probe timers dynamic #400

merged 2 commits into from
Jul 2, 2021

Conversation

sgontla
Copy link
Contributor

@sgontla sgontla commented Jul 2, 2021

  • Logic to dynamically adjust the Readiness and Liveness initial delay times to accommodate the app installations
  • config option to specific the Liveness and Readiness Probe initial delay time

@sgontla sgontla marked this pull request as draft July 2, 2021 01:53
@sgontla sgontla force-pushed the feature/cspl-1139 branch from 76b2edb to 9970bac Compare July 2, 2021 15:20
@sgontla
Copy link
Contributor Author

sgontla commented Jul 2, 2021

Just a note, dynamic delay calculation may need further tuning, based on our observations going forward, but the logic is not going to change much.

@sgontla sgontla marked this pull request as ready for review July 2, 2021 15:34
@sgontla sgontla force-pushed the feature/cspl-1139 branch from 9970bac to db9ba08 Compare July 2, 2021 15:41
@sgontla
cspl-1139: Make Probe timers dynamic
e483b16 
- Logic to dynamically adjust the Readiness and Liveness initial delay times to accommodate the app installations
- config option to specific the Liveness and Readiness Probe initial delay time
@sgontla sgontla force-pushed the feature/cspl-1139 branch from db9ba08 to e483b16 Compare July 2, 2021 15:45
gaurav-splunk
gaurav-splunk reviewed Jul 2, 2021
View reviewed changes
@smohan-splunk smohan-splunk merged commit 4b5db8c into feature-appframework Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav-splunk gaurav-splunk gaurav-splunk approved these changes

@kashok-splunk kashok-splunk Awaiting requested review from kashok-splunk

+2 more reviewers

@jryb jryb jryb approved these changes

@smohan-splunk smohan-splunk smohan-splunk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sgontla @jryb @smohan-splunk @gaurav-splunk