Skip to content

Conversation

kashok-splunk
Copy link
Contributor

@kashok-splunk kashok-splunk commented Jul 8, 2021

Full MC configuration/reconfiguration (All deployments other than IDC)
Example to create Standalone with mcRef

apiVersion: enterprise.splunk.com/v1
kind: Standalone
metadata:
  name: s2
  finalizers:
  - enterprise.splunk.com/delete-pvc
spec:
  monitoringConsoleRef:
    name: test

Comment on lines +878 to 915
monitoringConsoleRef:
description: MonitoringConsoleRef refers to a Splunk Enterprise monitoring
console managed by the operator within Kubernetes
properties:
apiVersion:
description: API version of the referent.
type: string
fieldPath:
description: 'If referring to a piece of an object instead of
an entire object, this string should contain a valid JSON/Go
field access statement, such as desiredState.manifest.containers[2].
For example, if the object reference is to a container within
a pod, this would take on a value like: "spec.containers{name}"
(where "name" refers to the name of the container that triggered
the event) or if no container name is specified "spec.containers[2]"
(container with index 2 in this pod). This syntax is chosen
only to have some well-defined way of referencing a part of
an object. TODO: this design is not final and this field is
subject to change in the future.'
type: string
kind:
description: 'Kind of the referent. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
type: string
name:
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names'
type: string
namespace:
description: 'Namespace of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/'
type: string
resourceVersion:
description: 'Specific resourceVersion to which this reference
is made, if any. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency'
type: string
uid:
description: 'UID of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids'
type: string
type: object
replicas:
Copy link
Contributor

@sgontla sgontla Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for IDXC? What will be the net effect, if somebody configures this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a discussion with Kriti:

  1. Good to have the MC ref as part of the MC CR, in case if we introduce the Global MC in the future.
  2. SHC (even if we have a separate CR in the future) needs the MC reference, as the logic expects both for the Deployer and SHs.
  3. IDXC case, each site-specific CR having MC reference can lead to confusion, as different sites can't go to different MCs. The best way is if we can pull this info from the CM CR, by reading it from the API server(?). If that is not feasible, an alternative can be using the configMap(CM writes it, and the site-specific CRs read and use it).

With the above understanding, we can continue using it in the current form(having the MC reference), but the implementation can ignore when dealing with the IDXC, and use it from the CM CR or through a configMap.

@smohan-splunk smohan-splunk merged commit 17b5e12 into feature-MC/CRD Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants