Cspl 1056 #405
Cspl 1056 #405
Conversation
|
For the cases, we deploy Standalone first before MC. Do we also need sanity test to deploy MC first and then standalone? |
pdhanoya-splunk
force-pushed
the
CSPL-1056
branch
2 times, most recently
from
7a3bb24 to
5cc4423
Compare
test/testenv/mcutil.go
Outdated
| mcConfigMapName := enterprise.GetSplunkMonitoringconsoleConfigMapName(deployment.GetName(), enterprise.SplunkMonitoringConsole) | ||
| mcConfigMap, err := GetConfigMap(deployment, ns, mcConfigMapName) | ||
| if err != nil { | ||
| logf.Log.Error(err, "Failed to get MC Conig Map") |
There was a problem hiding this comment.
nit: "Failed to get MC Config Map"
test/testenv/mcutil.go
Outdated
|
|
||
| // CheckPodNameInString checks for pod name in string | ||
| func CheckPodNameInString(podName string, configString string) bool { | ||
| logf.Log.Info("Check MC Config String has Pod configured", "MC CM String", configString, "POD String", podName) |
There was a problem hiding this comment.
Can we elaborate on this log? "MC CM String" is unclear
There was a problem hiding this comment.
Will do. This however common terminology we use internally but I do understand how this can be confusing.
|
|
||
| Context("Deploy Monitoring Console", func() { | ||
| It("smoke, monitoring_console: can deploy MC CR", func() { | ||
| It("smoke, monitoring_console: can deploy MC CR adn", func() { |
There was a problem hiding this comment.
typo. Will fix.
| 5. Verify Monitoring Console Pod has correct peers in Peer List | ||
| */ | ||
|
|
||
| // Deploy MC and wait for MC to be READY |
There was a problem hiding this comment.
nit: Isn't "wait for MC to be READY" part actually done on line 67?
There was a problem hiding this comment.
It supposed to be for the section from 62-67 however clearly its not clear I will modify
Covered as part of "smoke, monitoring_console: can deploy MC CR adn" |
pdhanoya-splunk
force-pushed
the
CSPL-1056
branch
2 times, most recently
from
00e0684 to
46ccb20
Compare
pdhanoya-splunk
force-pushed
the
CSPL-1056
branch
from
46ccb20 to
3bb549e
Compare
Automation for standalone instance with MC CRD: