Enabled EKS cluster for app fw test #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdhanoya-splunk
force-pushed
the
enable-eks-on-appfw-test
branch
from
3333876 to
1bf0fb2
Compare
smohan-splunk
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
This is an interim PR to confirm int-tests for app-framework execute successfully against the feature branch. A new PR will follow this one, which will effectively revert this PR and instead split the app-framework test cases into smoke & integration(nightly)
sgontla
reviewed
Jul 16, 2021
| fi | ||
|
|
||
| found=$(eksctl get cluster --name "${CLUSTER_NAME}" -v 0) | ||
| found=$(eksctl get cluster --name "${TEST_CLUSTER_NAME}" -v 0) |
There was a problem hiding this comment.
Don't we get some response data always? i.e even if the cluster is not available?. If so, the check below needs to be strengthened?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled EKS cluster for app fw test