CSPL-1193: update make_bundle.sh to fix removal of protocol field #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryb
approved these changes
Jul 16, 2021
sgontla
reviewed
Jul 16, 2021
sgontla
approved these changes
Jul 16, 2021
| for crd in `ls $1` | ||
| do | ||
| echo Updating crd: $crd | ||
| line_num=`grep -n "x-kubernetes-list-map-keys" $1/$crd | awk -F ":" '{print$1}'` |
There was a problem hiding this comment.
Temporary fix indeed, as slight change to the current order will disrupt the CRD. Hopefully next Operator SDK upgrade fixes this, at which time we should remember to revert. I have created CSPL-1194 to track this
smohan-splunk
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.