-
Notifications
You must be signed in to change notification settings - Fork 123
CSPL-1221: Manual trigger for app update #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryb
approved these changes
Aug 23, 2021
eddikay
approved these changes
Aug 24, 2021
sgontla
reviewed
Aug 24, 2021
sgontla
approved these changes
Aug 25, 2021
Had a discussion with @gaurav-splunk , and went through the changes. Some cases(which are not straightforward), will be considered later. Other than that as |
gaurav-splunk
added a commit
that referenced
this pull request
Sep 22, 2021
* CSPL-1221: Manual trigger for app update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets the manual trigger for app update. Here are the key changes -
appsRepoPollInterval=0
.status
toon
for that CR.off
again.Here is how the configMap looks like for a ClusterMaster and a Standalone CR type -
Current Limitation:
All the CRs of the same type with app framework enabled should be either using the manual app update or should be using the polling interval. We might target the mixed behavior in coming releases as an improvement.