CSPL-1235: Manual poll for app framework Automation #480

tpereirasplunk · 2021-08-23T18:27:07Z

Added test cases for S1, C3, M4 with manual poll

Test Scenario:

Setup config with app Framework enabled
System downloads Initial list of apps and installs them
Add new apps to S3
Set poll interval to 0 to disable polling
Wait for 2 mins to confirm that no apps were downloaded/installed/updated
Modify config map to trigger one time manual poll
Wait for system to be in ready state
Check pods for app install/update

Successful Run:

[2] • [SLOW TEST:479.969 seconds]
[2] s1appfw test
[2] /Users/tpereira/Git/splunk-operator/test/s1/appframework/appframework_test.go:31
[2]   appframework Standalone deployment (S1) with App Framework
[2]   /Users/tpereira/Git/splunk-operator/test/s1/appframework/appframework_test.go:249
[2]     appfwint, s1, appframework: can deploy a standalone instance with App Framework enabled for manual poll
[2]     /Users/tpereira/Git/splunk-operator/test/s1/appframework/appframework_test.go:250
[2] ------------------------------
[2] {"level":"info","ts":1629740550.3261619,"msg":"testenv deleted.\n","testenv":"s1appfw-fnq"}
[2]
[2] JUnit report was created: /Users/tpereira/Git/splunk-operator/test/s1/appframework/s1appfw-fnq_junit.xml
[2]
[2] Ran 1 of 3 Specs in 503.665 seconds
[2] SUCCESS! -- 1 Passed | 0 Failed | 2 Pending | 0 Skipped
[2] PASS


• [SLOW TEST:1559.642 seconds]
c3appfw test
/Users/tpereira/Git/splunk-operator/test/c3/appframework/appframework_test.go:30
  Single Site Indexer Cluster with SHC (C3) with App Framework
  /Users/tpereira/Git/splunk-operator/test/c3/appframework/appframework_test.go:558
    appfwint, c3, appframework: can deploy a C3 SVA with App Framework enabled for manual update
    /Users/tpereira/Git/splunk-operator/test/c3/appframework/appframework_test.go:559
------------------------------
{"level":"info","ts":1629928952.621782,"msg":"testenv deleted.\n","testenv":"c3appfw-yik"}
{"level":"info","ts":1629928952.621809,"msg":"testenv deleted.\n","testenv":"c3appfw-yik"}

JUnit report was created: /Users/tpereira/Git/splunk-operator/test/c3/appframework/c3appfw-yik_junit.xml

Ran 1 of 5 Specs in 1578.291 seconds
SUCCESS! -- 1 Passed | 0 Failed | 4 Pending | 0 Skipped
PASS


• [SLOW TEST:1180.835 seconds]
m4appfw test
/Users/tpereira/Git/splunk-operator/test/m4/appframework/appframework_test.go:30
  Multi Site Indexer Cluster with SHC (m4) with App Framework
  /Users/tpereira/Git/splunk-operator/test/m4/appframework/appframework_test.go:326
    m4, appframework: can deploy a M4 SVA with App Framework enabled for manual poll
    /Users/tpereira/Git/splunk-operator/test/m4/appframework/appframework_test.go:327
------------------------------
{"level":"info","ts":1629935341.705771,"msg":"testenv deleted.\n","testenv":"m4appfw-lah"}
{"level":"info","ts":1629935341.7058089,"msg":"testenv deleted.\n","testenv":"m4appfw-lah"}

JUnit report was created: /Users/tpereira/Git/splunk-operator/test/m4/appframework/m4appfw-lah_junit.xml

Ran 1 of 3 Specs in 1205.454 seconds
SUCCESS! -- 1 Passed | 0 Failed | 2 Pending | 0 Skipped
PASS

test/c3/appframework/appframework_test.go

test/testenv/util.go

test/testenv/appframework_utils.go

test/c3/appframework/appframework_test.go

test/m4/appframework/appframework_test.go

test/s1/appframework/appframework_test.go

sgontla · 2021-08-31T00:39:34Z

The changes look good to me.
Since the framework deals with the CR Kind to trigger the functionality, in addition to the test cases covered here, It will be valuable to have a test case with multiple CRs of the same kind, and also, deleting one CR / adding another CR, when others are dealing with the trigger, and see if the apps get installed successfully, also, leaving the configMap in a clean state at the end of the test. May be we can have a follow-up Jira, to get that kind of coverage(?).
CC: @gaurav-splunk

tpereirasplunk · 2021-08-31T00:52:11Z

The changes look good to me.
Since the framework deals with the CR Kind to trigger the functionality, in addition to the test cases covered here, It will be valuable to have a test case with multiple CRs of the same kind, and also, deleting one CR, when others are dealing with the trigger, and see if the apps get installed successfully, also, leaving the configMap in a clean state at the end of the test. May be we can have a follow-up Jira, to get that kind of coverage(?).
CC: @gaurav-splunk

We have ticket CSPL-1248 to look into those cases and another follow-up JIRA to automate the same

pdhanoya-splunk · 2021-09-02T16:09:13Z

test/testenv/util.go

 	return stdout, nil
 }

+// GetConfigMap Gets the config map for a given k8 config map name


Just checking. This copy of file from MC branch ?

smohan-splunk · 2021-09-02T17:52:18Z

test/c3/appframework/appframework_test.go

 	})
+
+	Context("Single Site Indexer Cluster with SHC (C3) with App Framework", func() {
+		It("appfwint, c3, appframework: can deploy a C3 SVA with App Framework enabled for manual update", func() {


Should appfwint be replaced with integration? cc: @pdhanoyasplunk

Thanks for catching it. Yes we should replace it with integration.

pdhanoya-splunk · 2021-09-02T18:11:49Z

test/m4/appframework/appframework_test.go

 	})
+
+	Context("Multi Site Indexer Cluster with SHC (m4) with App Framework", func() {
+		It("m4, appframework: can deploy a M4 SVA with App Framework enabled for manual poll", func() {


Add integration keyword.

pdhanoya-splunk · 2021-09-02T18:12:20Z

test/s1/appframework/appframework_test.go

 	})
+
+	Context("appframework Standalone deployment (S1) with App Framework", func() {
+		It("appfwint, s1, appframework: can deploy a standalone instance with App Framework enabled for manual poll", func() {


Remove appfwint and add integration keyword

smohan-splunk · 2021-09-02T23:08:32Z

test/testenv/util.go

 }
+
+// GeneratePodNameSlice returns slice of PodNames based on given key and count.
+func GeneratePodNameSlice(formatString string, key string, count int, multisite bool, siteCount int) []string {


Doesn't look like this is being used..meant for future? Any idea @pdhanoyasplunk or @jambrosiano ?

This file is brought in from MC feature branch where this method is used.

As discussed, this will cause a conflict in one of the feature branches when the first one gets merged to develop. Will merge this for now, but in the future request is to add common functions to develop and pull them into the feature branches to avoid additional conflict resolution work

cc: @kashok-splunk , @sgontla , @gaurav-splunk

tpereirasplunk requested review from pdhanoya-splunk, jambrosiano and sgontla August 23, 2021 22:15

gaurav-splunk reviewed Aug 24, 2021

View reviewed changes

test/c3/appframework/appframework_test.go Show resolved Hide resolved

pdhanoya-splunk suggested changes Aug 24, 2021

View reviewed changes

test/testenv/util.go Outdated Show resolved Hide resolved

test/testenv/appframework_utils.go Show resolved Hide resolved

tpereirasplunk force-pushed the CSPL-1235 branch 2 times, most recently from b01591f to 6775157 Compare August 26, 2021 00:49

tpereirasplunk requested review from pdhanoya-splunk, gaurav-splunk, smohan-splunk, vebken-splunk, jryb, akondur and kumarajeet August 26, 2021 16:13

tpereirasplunk force-pushed the CSPL-1235 branch from 6775157 to 8baef48 Compare August 26, 2021 16:15

tpereirasplunk changed the title ~~CSPL-1235: Manual poll~~ CSPL-1235: Manual poll for app framework Automation Aug 26, 2021

gaurav-splunk reviewed Aug 26, 2021

View reviewed changes

test/c3/appframework/appframework_test.go Show resolved Hide resolved

test/m4/appframework/appframework_test.go Show resolved Hide resolved

test/s1/appframework/appframework_test.go Show resolved Hide resolved

tpereirasplunk force-pushed the CSPL-1235 branch from 8baef48 to 38d08bd Compare August 26, 2021 21:46

gaurav-splunk approved these changes Aug 27, 2021

View reviewed changes

sgontla approved these changes Aug 31, 2021

View reviewed changes

pdhanoya-splunk reviewed Sep 2, 2021

View reviewed changes

pdhanoya-splunk approved these changes Sep 2, 2021

View reviewed changes

jambrosiano approved these changes Sep 2, 2021

View reviewed changes

smohan-splunk reviewed Sep 2, 2021

View reviewed changes

pdhanoya-splunk reviewed Sep 2, 2021

View reviewed changes

pdhanoya-splunk suggested changes Sep 2, 2021

View reviewed changes

pdhanoya-splunk force-pushed the CSPL-1235 branch from 38d08bd to 231a922 Compare September 2, 2021 18:18

pdhanoya-splunk approved these changes Sep 2, 2021

View reviewed changes

pdhanoya-splunk force-pushed the CSPL-1235 branch from 231a922 to 688fb66 Compare September 2, 2021 18:28

pdhanoya-splunk marked this pull request as draft September 2, 2021 18:36

pdhanoya-splunk marked this pull request as ready for review September 2, 2021 21:54

pdhanoya-splunk changed the base branch from feature-appframework to develop September 2, 2021 21:54

pdhanoya-splunk changed the base branch from develop to feature-appframework September 2, 2021 21:55

CSPL-1235: Manual poll

a96c6cd

pdhanoya-splunk force-pushed the CSPL-1235 branch from 688fb66 to a96c6cd Compare September 2, 2021 22:22

smohan-splunk approved these changes Sep 2, 2021

View reviewed changes

smohan-splunk approved these changes Sep 3, 2021

View reviewed changes

smohan-splunk merged commit 0f3f74f into feature-appframework Sep 3, 2021

gaurav-splunk pushed a commit that referenced this pull request Sep 22, 2021

CSPL-1235: Manual poll (#480)

5280801

tpereirasplunk deleted the CSPL-1235 branch October 29, 2021 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CSPL-1235: Manual poll for app framework Automation #480

CSPL-1235: Manual poll for app framework Automation #480

Uh oh!

tpereirasplunk commented Aug 23, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sgontla commented Aug 31, 2021 •

edited

Loading

Uh oh!

tpereirasplunk commented Aug 31, 2021

Uh oh!

pdhanoya-splunk Sep 2, 2021

Uh oh!

smohan-splunk Sep 2, 2021

Uh oh!

pdhanoya-splunk Sep 2, 2021

Uh oh!

pdhanoya-splunk Sep 2, 2021

Uh oh!

pdhanoya-splunk Sep 2, 2021

Uh oh!

smohan-splunk Sep 2, 2021

Uh oh!

pdhanoya-splunk Sep 2, 2021

Uh oh!

smohan-splunk Sep 3, 2021 •

edited

Loading

Uh oh!

Uh oh!

CSPL-1235: Manual poll for app framework Automation #480

CSPL-1235: Manual poll for app framework Automation #480

Uh oh!

Conversation

tpereirasplunk commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sgontla commented Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tpereirasplunk commented Aug 31, 2021

Uh oh!

pdhanoya-splunk Sep 2, 2021

Choose a reason for hiding this comment

Uh oh!

smohan-splunk Sep 2, 2021

Choose a reason for hiding this comment

Uh oh!

pdhanoya-splunk Sep 2, 2021

Choose a reason for hiding this comment

Uh oh!

pdhanoya-splunk Sep 2, 2021

Choose a reason for hiding this comment

Uh oh!

pdhanoya-splunk Sep 2, 2021

Choose a reason for hiding this comment

Uh oh!

smohan-splunk Sep 2, 2021

Choose a reason for hiding this comment

Uh oh!

pdhanoya-splunk Sep 2, 2021

Choose a reason for hiding this comment

Uh oh!

smohan-splunk Sep 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tpereirasplunk commented Aug 23, 2021 •

edited

Loading

sgontla commented Aug 31, 2021 •

edited

Loading

smohan-splunk Sep 3, 2021 •

edited

Loading