CSPL 1180 - CRD apiVersioning change from V2 to V3 #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashok-splunk
changed the title
kashok-splunk
commented
Sep 8, 2021
| } else { | ||
| result.Requeue = false | ||
| } | ||
|
|
There was a problem hiding this comment.
Duplicate Code. Was added twice by mistake when resolving merge conflicts, on merging develop to MC feature branch
kashok-splunk
commented
Sep 8, 2021
| result.Requeue = false | ||
| } | ||
|
|
||
| // Requeue the reconcile after polling interval if we had set the lastAppInfoCheckTime. |
There was a problem hiding this comment.
Duplicate Code. Was added twice by mistake when resolving merge conflicts, on merging develop to MC feature branch
kashok-splunk
commented
Sep 8, 2021
| } else { | ||
| result.Requeue = false | ||
| } | ||
|
|
There was a problem hiding this comment.
Duplicate Code. Was added twice by mistake when resolving merge conflicts, on merging develop to MC feature branch
kashok-splunk
requested review from
smohan-splunk,
sgontla,
pdhanoya-splunk,
gaurav-splunk and
jryb
jryb
approved these changes
Sep 8, 2021
sgontla
reviewed
Sep 9, 2021
sgontla
approved these changes
Sep 9, 2021
smohan-splunk
approved these changes
Sep 9, 2021
gaurav-splunk
approved these changes
Sep 10, 2021
kashok-splunk
force-pushed
the
CSPL-1180
branch
from
d300081 to
c9a1b5e
Compare
kashok-splunk
force-pushed
the
CSPL-1180
branch
from
c9a1b5e to
c581cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRD apiVersioning change from V2 to V3