Skip to content

Support taint toleration #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

Support taint toleration #73

merged 1 commit into from
Apr 24, 2020

Conversation

kelvinatsplunk
Copy link
Contributor

#67

  • Add tolerations field to CommonSpec to pass thru to StatefulSet and Deployment (Spark)
  • Refactored CompareXXX() routines to use sortAndCompareSlices()

mikedickey
mikedickey approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@mikedickey mikedickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sortAndCompareSlices - very nice!

Why did code coverage drop for this change?

@kelvinatsplunk
Copy link
Contributor Author

@mikedickey Not sure why code coverage drop but looking to add more test.

@kelvinatsplunk kelvinatsplunk force-pushed the support-taint-toleration branch from f39c96c to e510c28 Compare April 23, 2020 00:00
@kelvinatsplunk kelvinatsplunk mentioned this pull request Apr 23, 2020
Closed
@kelvinatsplunk kelvinatsplunk force-pushed the support-taint-toleration branch from 63d3bbd to 1c7f17b Compare April 23, 2020 17:51
@kelvinatsplunk kelvinatsplunk merged commit 8f3a5af into master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjothikumar-splunk gjothikumar-splunk Awaiting requested review from gjothikumar-splunk

1 more reviewer

@mikedickey mikedickey mikedickey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvinatsplunk @mikedickey