Skip to content

Conversation

tltx
Copy link
Contributor

@tltx tltx commented Jun 29, 2017

Here is some work I done to add Python 3 support. It's not finished and I can't get the tests to work in python 2 so it's hard to know what more needs to be done. If you have any tips on how fix "Connection refused" problem with the tests I can test more myself.

@tltx tltx force-pushed the master branch 16 times, most recently from f95389a to 185b7ee Compare July 3, 2017 10:51
@tltx
Copy link
Contributor Author

tltx commented Jul 3, 2017

I have fixed the remaining issues I found. The test suite is kind if flakey but that does not seem to be related to Python 3. I think this PR is ready for regression testing and review.

@tdhellmann
Copy link
Contributor

Thanks so much for this PR! We're definitely eager to take a look, and our intention is to do what we can to take the change. That said, we also want to be upfront that we're in the middle of the next release of Splunk Enterprise at the moment, so it's going to take us a little bit of time to review the PR and land it. We want to make sure we're ready on our end to fully support Python 3 after the PR is merged, and that requires some dedicated time on our end.

Thanks again for the contribution!

@brandonmburroughs
Copy link

@tdhellmann Is there any update here? I've been using the Splunk Python SDK and would love for it to have Python 3 support and better integrate with the rest of my project! I'd be happy to help @tltx update whatever conflicts there now are if this will get tested/merged. Thanks!

@vaputa vaputa mentioned this pull request Feb 23, 2018
@shakeelmohamed shakeelmohamed merged commit 4503db9 into splunk:develop Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants