-
Notifications
You must be signed in to change notification settings - Fork 385
Replace tox
with pytest
and Makefile
, cleanup in docs/Makefile
#669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
fb9c056
Remove unused code from docs Makefile
Ickerday 2f77a2f
Fix missing backtick in docstring
Ickerday f77ffdb
Remove tox
Ickerday a12dc5f
Add programmatic year setting in docs
Ickerday b842d41
Move python version string to env, use dependency groups in pre-relea…
Ickerday 4982b68
Sync pre-release.yml to release.yml
Ickerday 485e80c
Add "Python 3 Only" classifier
Ickerday 1656286
Update missed deps installation statement in test.yml
Ickerday 92bb926
Run linter on CHANGELOG.md, fix typos
Ickerday 96baeca
Capitalize some terms in CHANGELOG
Ickerday d9abd16
Add unfortunate workaround for deps installation in Python 3.7 in CI
Ickerday a54d756
Unify naming in GH Action workflows
Ickerday 324669e
Fix missing dependencies in test suite 🤦
Ickerday d898ac5
Use latest release of splunk-app-collection
Ickerday b1edb7c
Separate .PHONY-ies as they look better; Update README.md
Ickerday 7531347
uv.lock
Ickerday 9000d33
More cleanup in `Makefile`s
Ickerday fd3a218
Fix "Converting `source_suffix = '.rst'` to `source_suffix = {'.rst':…
Ickerday 70c3f74
Refactor README
Ickerday 81695d6
Refactor README #2
Ickerday 7938b65
Finish cleanup in Makefile
Ickerday 3ae152b
Spruce up example app names etc.
Ickerday 37d5537
Separate app dependency install for Python 3.7 and the rest
Ickerday 11ada60
Rewrite installation section in README
Ickerday a6b0e1d
Drop `deprecation` from dependencies in test.yml
Ickerday ff22dcc
PR review changes
Ickerday 2c1d6ef
Another README refactor
Ickerday 9ef5a4f
Run `mbake` on `Makefile`s
Ickerday 25932cc
Pin dependencies in `pyproject.toml` wherever possible
Ickerday b42ebc7
Adjust details in README
Ickerday 6cc6dde
Retires -> retries
Ickerday 996e5aa
Last adjustments to README
Ickerday df67581
Adjust docstring in client.py
Ickerday 255830d
PR review adjustments
Ickerday File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
[run] | ||
omit = | ||
.tox/* | ||
tests/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,56 +1,48 @@ | ||
RESET_COLOR=\033[0m | ||
GREEN_COLOR=\033[32;01m | ||
|
||
CONTAINER_NAME := 'splunk' | ||
CONTAINER_NAME := "splunk" | ||
|
||
.PHONY: docs | ||
docs: | ||
@echo "$(GREEN_COLOR)==> docs $(RESET_COLOR)" | ||
@rm -rf ./docs/_build | ||
@tox -e docs | ||
@cd ./docs/_build/html && zip -r ../docs_html.zip . -x ".*" -x "__MACOSX" | ||
@echo "$(ATTN_COLOR)==> Docs pages can be found at ./docs/_build/html, docs bundle available at ./docs/_build/docs_html.zip" | ||
@make -C ./docs html | ||
|
||
.PHONY: test | ||
test: | ||
@echo "$(GREEN_COLOR)==> test $(RESET_COLOR)" | ||
@tox -e py -- ./tests | ||
@python -m pytest ./tests | ||
|
||
.PHONY: test-unit | ||
test: | ||
@echo "$(GREEN_COLOR)==> test $(RESET_COLOR)" | ||
@tox -e py -- ./tests/unit | ||
test-unit: | ||
@python -m pytest ./tests/unit | ||
|
||
.PHONY: test-integration | ||
test: | ||
@echo "$(GREEN_COLOR)==> test $(RESET_COLOR)" | ||
@tox -e py -- ./tests/integration ./tests/system | ||
test-integration: | ||
@python -m pytest ./tests/integration ./tests/system | ||
|
||
.PHONY: up | ||
up: | ||
@echo "$(GREEN_COLOR)==> up $(RESET_COLOR)" | ||
.PHONY: docker-up | ||
docker-up: | ||
@docker-compose up -d | ||
|
||
.PHONY: remove | ||
remove: | ||
@echo "$(GREEN_COLOR)==> rm $(RESET_COLOR)" | ||
@docker-compose rm -f -s | ||
|
||
.PHONY: wait_up | ||
wait_up: | ||
@echo "$(GREEN_COLOR)==> wait_up $(RESET_COLOR)" | ||
@for i in `seq 0 180`; do if docker exec -it $(CONTAINER_NAME) /sbin/checkstate.sh &> /dev/null; then break; fi; printf "\rWaiting for Splunk for %s seconds..." $$i; sleep 1; done | ||
|
||
.PHONY: down | ||
down: | ||
@echo "$(GREEN_COLOR)==> down $(RESET_COLOR)" | ||
.PHONY: docker-ensure-up | ||
docker-ensure-up: | ||
@for i in `seq 0 180`; do \ | ||
if docker exec -it $(CONTAINER_NAME) /bin/bash -c "/sbin/checkstate.sh &> /dev/null"; then \ | ||
break; \ | ||
fi; \ | ||
printf "\rWaiting for Splunk for %s seconds..." $$i; \ | ||
sleep 1; \ | ||
done | ||
|
||
.PHONY: docker-start | ||
mateusz834 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
docker-start: docker-up docker-ensure-up | ||
|
||
.PHONY: docker-down | ||
docker-down: | ||
@docker-compose stop | ||
|
||
.PHONY: start | ||
start: up wait_up | ||
.PHONY: docker-restart | ||
docker-restart: docker-down docker-start | ||
|
||
.PHONY: restart | ||
restart: down start | ||
.PHONY: docker-remove | ||
docker-remove: | ||
@docker-compose rm -f -s | ||
|
||
.PHONY: refresh | ||
refresh: remove start | ||
.PHONY: docker-refresh | ||
docker-refresh: docker-remove docker-start |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.