Patch lib to work with MongoDB 4.x

[cortezcristian]

Issue: mongo-backup-streaming was working with MongoDB 3.x

After looking at the documentation I was able to make a patch on the library, tons of things got deprecated on new mongodb official package version. In example:

https://stackoverflow.com/a/47694265/467034
http://mongodb.github.io/node-mongodb-native/3.1/api/Cursor.html#snapshot
https://stackoverflow.com/a/50597669/467034

[spmiller]

Hi @cortezcristian, thanks for your PR. I believe upstream is targetting mongo 2 for the widest compatibility -- is your change backwards compatible with Mongo 2 and 3?

[cortezcristian]

Hello @spmiller: No, is not compatible with previous versions. And this is inherited by the driver package breaking changes from mongodb@2.2.26 to mongodb@3.1.13 npm core dependency.

NOTE: v3.x was recently released with breaking API changes. You can find a list of changes here. https://github.com/mongodb/node-mongodb-native/blob/master/CHANGES_3.0.0.md#features

[spmiller]

Hi @cortezcristian, sorry for the late response. I'm still hopeful that upstream will accept my pull request, so I want to maintain support for the same Mongo versions. However, I am still confused about backwards-compatibility.

I've reviewed the document you linked to above, and I think it says the driver API is not backwards compatible (i.e. it has breaking changes). However, if I look at the driver compatibility table, it seems to show that newer versions of the driver maintain compatibility with Mongo 2.6.

Is this your understanding too? If so, I think we will be able to merge this.

[Phoscur]

I'd like to see all changes for MongoDB v4 compatbility merged and published asap (including mine from hex7c0#27).
Are you going to do it?
A better way might be just going with MGOB..

[spmiller]

Hi @Phoscur, I was waiting for @cortezcristian to reply to my previous message before moving forwards here. I'm also not the owner of upstream -- this is just a fork I made for some streaming support, so I'm afraid I can't help you there :(

[cortezcristian]

Hi all, my fix has no backwards compatibility. Already exchanged some emails with @Phoscur, I believe he published his own package with small modifications. We can close this PR, cause i'm using my own package that is not backwards compatible https://www.npmjs.com/package/mongodb-backup-stream-4x

[Phoscur]

See hex7c0#27