Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Build on Windows #38

Merged
merged 1 commit into from
Aug 31, 2014
Merged

Conversation

selenium34
Copy link
Contributor

Builds on windows were failing due to specs relying on *Nix line endings
/ file separators.

Builds on windows were failing due to specs relying on *Nix line endings
/ file separators.
@Fuud
Copy link
Contributor

Fuud commented Aug 30, 2014

@pniederw @alkemist This issue affects all who want develop Spock under Windows. Can you please merge this pull-request. Thanks.

@pniederw pniederw merged commit af934f3 into spockframework:groovy-1.8 Aug 31, 2014
@pniederw
Copy link
Contributor

This is now merged. Thanks for the PR and reminder. I'm currently setting up a Windows CI build to detect such problems sooner in the future.

@selenium34
Copy link
Contributor Author

From what I remember I used three different methodologies to resolve this issue with the thought that a single consolidated utility might be created to resolve in a consistent fashion.

When I created the request, I didn't see anything I could easily reuse, hence the potpourri of replacement methods.

@pniederw
Copy link
Contributor

Agreed. Perhaps TextUtil#normalizeLineSeparators and IoUtil#normalizeFileSeparators could be added. Even better if Spock offered a public API for solving such problems, as users will likely run into them as well.

Another simplification would be to use String#replace instead of String#replaceAll.

@selenium34
Copy link
Contributor Author

That would be nice.

I should have commented as such when i originally submitted the thought process on the inconsistency.

@pniederw
Copy link
Contributor

No problem. Good news it that we now have a Windows CI build: https://ci.appveyor.com/project/pniederw/spock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants