Add RepositoryClient.listPullRequestsForCommit #100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
============================================
+ Coverage 70.62% 70.76% +0.13%
- Complexity 225 226 +1
============================================
Files 36 36
Lines 851 855 +4
Branches 35 35
============================================
+ Hits 601 605 +4
Misses 225 225
Partials 25 25
Continue to review full report at Codecov.
|
|
Yes I think we don't need this and don't do pagination anywhere else. Let's keep it simple for now and add it if we need it later. I don't think it's ever needed in this case: will there ever be more than 30 PRs containing the same commit? Probably not 😉 |
| import java.util.Optional; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.CompletionException; | ||
| import javax.ws.rs.core.HttpHeaders; |
There was a problem hiding this comment.
There is an alternative class which we could use com.google.common.net.HttpHeaders
There was a problem hiding this comment.
I just copied this from other classes in this project, doesn't matter much I think 🤷
| final String path = String.format(COMMIT_PULL_REQUESTS_SHA_URI_TEMPLATE, owner, repo, sha); | ||
|
|
||
| // As of GHE 3.2, this feature is still in preview, so we need to add the extra header. | ||
| // https://developer.github.com/changes/2019-04-11-pulls-branches-for-commit/ |
| json.fromJson("[" + getFixture("../prs/pull_request_item.json") + "]", LIST_PR_TYPE_REFERENCE)); | ||
| when(github.request(eq("/repos/someowner/somerepo/commits/thesha/pulls"), eq(LIST_PR_TYPE_REFERENCE), any())) | ||
| .thenReturn(fixture); | ||
| final List<PullRequestItem> commits = repoClient.listPullRequestsForCommit("thesha").get(); |
There was a problem hiding this comment.
Does it return commits? Or pull requests? if the latter is true, should be renamed to pullRequests? (as list)
See https://docs.github.com/en/enterprise-server@3.2/rest/commits/commits#list-pull-requests-associated-with-a-commit