Skip to content

feat(pull-request): support pagination in list commits #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025

Conversation

sarlam
Copy link
Contributor

@sarlam sarlam commented Jun 24, 2025

Summary

This pull request adds full support for pagination when listing commits for a given Pull Request

WORK IN PROGRESS

@sarlam sarlam requested a review from Abhi347 June 24, 2025 10:16
@sarlam sarlam self-assigned this Jun 24, 2025
@sarlam sarlam added the enhancement New feature or request label Jun 24, 2025
@sarlam sarlam marked this pull request as ready for review June 24, 2025 15:01
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (d2b4785) to head (79b63d4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...java/com/spotify/github/v3/clients/GithubPage.java 90.00% 2 Missing and 1 partial ⚠️
...m/spotify/github/v3/clients/PullRequestClient.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     77.12%   77.77%   +0.65%     
- Complexity      437      445       +8     
============================================
  Files            60       60              
  Lines          1403     1422      +19     
  Branches         60       61       +1     
============================================
+ Hits           1082     1106      +24     
+ Misses          277      271       -6     
- Partials         44       45       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarlam sarlam changed the title feat(pull-request): support pagination in list commits (bisect: bad) feat(pull-request): support pagination in list commits Jun 25, 2025
dennisgranath
dennisgranath previously approved these changes Jun 25, 2025
sarlam added 5 commits June 26, 2025 11:25
Summary
=======

This commits introduces a test as a ground base to sustain full pagination when listing commits from a pull request

WORK IN PROGRESS
Summary
=======

implements the per pages limit
Summary
=======

This introduce a new methods that returns a paginated version of the endpoint listCommits in a pull request context
@sarlam sarlam force-pushed the feat/pageinated_list_commit branch from b1b2723 to 79b63d4 Compare June 26, 2025 09:29
@sarlam sarlam enabled auto-merge (squash) June 26, 2025 09:30
@sarlam sarlam requested a review from dennisgranath June 26, 2025 09:30
@sarlam sarlam merged commit 900ea76 into master Jun 26, 2025
3 checks passed
@sarlam sarlam deleted the feat/pageinated_list_commit branch June 26, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants