fix tests that fail for the wrong reasons #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the test `assertJwtEndpointWithNoKeyThrows()` was taking 10 seconds to run so I took a look into why that was. The test method has `@Test(expected=Exception.class)` but the exception that is thrown is different than the one that the test is expected - the test was throwing a SocketTimeoutException after 10 seconds (which is the OkHttpClient's default read timeout setting) because there was no mock requests enqueued in the mock web server. I refactored these tests to use `assertThrows` instead to assert against the details of the thrown Exceptions, and also fixed what seems like a bug in the `getAuthorizationHeader` method - if the client has an accessToken, it will be used as the header, even if the request path is one that needs a private-key-signed JWT token.
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
============================================
+ Coverage 65.80% 67.94% +2.14%
- Complexity 176 191 +15
============================================
Files 30 32 +2
Lines 731 758 +27
Branches 29 31 +2
============================================
+ Hits 481 515 +34
+ Misses 229 222 -7
Partials 21 21
Continue to review full report at Codecov.
|
henriquetruta
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the test
assertJwtEndpointWithNoKeyThrows()was taking10 seconds to run so I took a look into why that was.
The test method has
@Test(expected=Exception.class)but the exceptionthat is thrown is different than the one that the test is expected - the
test was throwing a SocketTimeoutException after 10 seconds (which is
the OkHttpClient's default read timeout setting) because there was no
mock requests enqueued in the mock web server.
I refactored these tests to use
assertThrowsinstead to assert againstthe details of the thrown Exceptions, and also fixed what seems like a
bug in the
getAuthorizationHeadermethod - if the client has anaccessToken, it will be used as the header, even if the request path is
one that needs a private-key-signed JWT token.