Skip to content

Conversation

GriffinCodes
Copy link
Contributor

@GriffinCodes GriffinCodes commented Aug 28, 2021

The current readme has a bit of repetition, and some of the examples are completely wrong. For example:

// This method no longer exists, you have to authenticate
final GitHubClient github = GitHubClient.create(URI.create("https://api.github.com/"));
// IssueApi is now IssueClient
final IssueApi issueClient = github.createRepositoryClient("my-org", "my-repo").createIssueClient();
// listComments returns an Iterator, not a CompletableFuture
issueClient.listComments(ISSUE_ID).get().forEach(comment -> log.info(comment.body()));

Hopefully this makes the introduction to the project a bit smoother 🙂

Also, #63 was already fixed and can be closed

Copy link
Contributor

@barbatron barbatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty 🙏

@barbatron barbatron merged commit 6b00fcd into spotify:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants