Fix javadoc generation #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specify javadoc target release to fix java version mismatch errors - Remove lots of workarounds that are no longer needed - Run javadoc in all profiles to catch errors during PR testing, not just before publishing a release
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=========================================
Coverage 70.20% 70.20%
Complexity 222 222
=========================================
Files 36 36
Lines 866 866
Branches 36 36
=========================================
Hits 608 608
Misses 233 233
Partials 25 25 Continue to review full report at Codecov.
|
vchernodon
approved these changes
Apr 13, 2022
|
The problem with that is that we don't notice if a PR (with a pom upgrade or similar) breaks the javadoc build. It only adds a few more seconds to the entire build time, so it's probably best to just always generate them. |
sathish-kumar-subramani
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just before publishing a release