Add HTTP method to RequestNotOkException #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
============================================
+ Coverage 70.43% 70.62% +0.18%
- Complexity 223 225 +2
============================================
Files 36 36
Lines 849 851 +2
Branches 35 35
============================================
+ Hits 598 601 +3
+ Misses 226 225 -1
Partials 25 25
Continue to review full report at Codecov.
|
dziemba
force-pushed
the
exception-http-verb
branch
from
85f4072 to
82d49ba
Compare
Adding the HTTP method to the failure exception allows for better visibility into which call exactly failed. We already had the HTTP path in the exception but there are usually multiple HTTP methods that are valid for a single path.
dziemba
force-pushed
the
exception-http-verb
branch
from
82d49ba to
2877a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the HTTP method to the failure exception allows for better
visibility into which call exactly failed. We already had the HTTP path
in the exception but there are usually multiple HTTP methods that are
valid for a single path.