Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hinting and stub files for editor autocomplete. #117

Merged
merged 35 commits into from
Jul 13, 2022
Merged

Conversation

psobot
Copy link
Member

@psobot psobot commented Jul 12, 2022

This PR should add type hints to allow editors like VS Code and PyCharm to autocomplete classes, functions, and constants in Pedalboard. A test is also added to ensure that stub files don't drift from the actual runtime implementation.

@psobot psobot added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 12, 2022
Copy link
Contributor

@drubinstein drubinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

pedalboard/__init__.pyi Show resolved Hide resolved
pedalboard/__init__.pyi Outdated Show resolved Hide resolved
pedalboard/__init__.pyi Outdated Show resolved Hide resolved
pedalboard/__init__.pyi Outdated Show resolved Hide resolved
pedalboard/io/__init__.pyi Outdated Show resolved Hide resolved
pedalboard/io/__init__.pyi Outdated Show resolved Hide resolved
pedalboard/io/__init__.pyi Outdated Show resolved Hide resolved
pedalboard/pedalboard.py Outdated Show resolved Hide resolved
@psobot psobot merged commit c3a7c78 into master Jul 13, 2022
@psobot psobot deleted the psobot/stubs branch July 13, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants