Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade zoltar to 0.5.6 #2318

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Conversation

mattnworb
Copy link
Member

@mattnworb mattnworb commented Oct 23, 2019

This re-applies #2254 now that zoltar is using Tensorflow 1.15 (spotify/zoltar#193)

This re-applies spotify#2254 now that
zoltar is using Tensorflow 1.15
(spotify/zoltar#193)
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #2318 into master will decrease coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2318      +/-   ##
==========================================
- Coverage   70.06%   68.73%   -1.33%     
==========================================
  Files         240      238       -2     
  Lines        7767     7747      -20     
  Branches      365      398      +33     
==========================================
- Hits         5442     5325     -117     
- Misses       2325     2422      +97
Impacted Files Coverage Δ
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-66.67%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-52.5%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-41.18%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0% <0%> (-31.71%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 65% <0%> (-30%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 33.33% <0%> (-27.28%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 52.17% <0%> (-21.74%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 37.86% <0%> (-3.4%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 28.94% <0%> (-2.64%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0% <0%> (-1.77%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82c432...99d3dc1. Read the comment docs.

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #2319

@regadas regadas merged commit a258543 into spotify:master Oct 24, 2019
regadas pushed a commit that referenced this pull request Oct 28, 2019
This re-applies #2254 now that
zoltar is using Tensorflow 1.15
(spotify/zoltar#193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants