Make checkVersion more dynamic #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5282 +/- ##
==========================================
+ Coverage 62.50% 62.62% +0.11%
==========================================
Files 301 301
Lines 10851 10843 -8
Branches 732 753 +21
==========================================
+ Hits 6782 6790 +8
+ Misses 4069 4053 -16 ☔ View full report in Codecov by Sentry. |
clairemcginty
approved these changes
Feb 28, 2024
|
The checks were useless, we were not able to display a 'forward' migration as we can't be aware of the future migration pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scio is not able to link to future migration resources.
Make
checkVersionmore dynamic by testing if a migration page exists in case of breaking version upgrade