Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix #5290) Support empty input in TrasnformOverride.ofSource #5293

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

clairemcginty
Copy link
Contributor

unfortunately this requires changing the signature to require a Coder.

.run()
}

it should "pass with a 1-to-n override" in {
"TransformOverride.ofIter" should "support 1-to-n inputs" in {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this diff is just rearranging the tests to be grouped by API:

[info] JobTest
...
[info] transformOverride.ofSource
[info] - should support non-empty input (69 milliseconds)
[info] - should support empty input (78 milliseconds)
[info] TransformOverride.ofIter
[info] - should support 1-to-n inputs (147 milliseconds)
[info] - should support 1-to-n function inputs (56 milliseconds)
[info] TransformOverride.of
[info] - should support non-empty input (66 milliseconds)
[info] - should support function input (56 milliseconds)
[info] - should fail with an incorrect override input type (27 milliseconds)
[info] - should fail with an incorrect function override input type (40 milliseconds)
[info] - should fail differently with an incorrect override generic input type (69 milliseconds)
[info] - should fail with an incorrect override output type (30 milliseconds)
[info] TransformOverride.ofKV
[info] - should support non-empty input (56 milliseconds)
[info] - should suppport a KV function override (50 milliseconds)
[info] TransformOverride.ofIterKV
[info] - should support non-empty input (60 milliseconds)
[info] - should support a 1-to-n KV function input (57 milliseconds)
[info] TransformOverride.ofAsyncLookup
[info] - should support non-empty input (55 milliseconds)
[info] - should pass with an AsyncLookup function override (55 milliseconds)
[info] TransformOverride.ofIterAsyncLookup
[info] - should support a 1-to-n AsyncLookup function override (53 milliseconds)
[info] - should support a 1-to-n AsyncLookup override (55 milliseconds)

@RustedBones
Copy link
Contributor

I think this is still worth adding this breaking change in the next 0.14 patch. Let's add a filtering to the mima

@clairemcginty clairemcginty merged commit 40c900b into main Mar 7, 2024
11 checks passed
@clairemcginty clairemcginty deleted the transform-override-emptysource branch March 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants