This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Support more flyte types #1093
Merged
Support more flyte types #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgomezfrr
force-pushed
the
support-more-flyte-inputs
branch
from
6f98dfe
to
ea8d105
Compare
pablocasares
approved these changes
Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
============================================
+ Coverage 92.33% 92.44% +0.10%
- Complexity 2150 2152 +2
============================================
Files 200 200
Lines 8326 8326
Branches 504 504
============================================
+ Hits 7688 7697 +9
+ Misses 522 515 -7
+ Partials 116 114 -2 |
honnix
reviewed
Jul 6, 2023
| private static final Set<TypeCase> COMPLEX_TYPES = | ||
| Set.of(TypeCase.COLLECTION_TYPE, TypeCase.MAP_VALUE_TYPE); | ||
|
|
||
| private static final ObjectMapper mapper = new ObjectMapper(new YAMLFactory()); |
There was a problem hiding this comment.
honnix
reviewed
Jul 6, 2023
| try { | ||
| return parseCollectionType(key, value, literalType.getCollectionType()); | ||
| } catch (Exception ex) { | ||
| throw new UnsupportedOperationException( |
There was a problem hiding this comment.
It's a good practice to chain exceptions so we don't loose the full stacktrace.
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Add support to DURATION/INTEGER/FLOAT/MAP/COLLECTION flyte inputs.
Motivation and Context
Have you tested this? If so, how?
Checklist for PR author(s)
Checklist for PR reviewer(s)