Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Refactor exceptions and yaml parser #1094

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

pablocasares
Copy link
Contributor

Hey, I just made a Pull Request!

Description

This PR is a refactor of #1093

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • (optional) Changes are covered by system test
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1094 (eaad196) into master (705bab4) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1094      +/-   ##
============================================
+ Coverage     92.26%   92.28%   +0.02%     
  Complexity     2150     2150              
============================================
  Files           200      200              
  Lines          8325     8325              
  Branches        504      504              
============================================
+ Hits           7681     7683       +2     
+ Misses          528      527       -1     
+ Partials        116      115       -1     

@pablocasares pablocasares requested a review from honnix July 6, 2023 14:23
@pablocasares pablocasares requested a review from honnix July 6, 2023 14:39
@andresgomezfrr andresgomezfrr merged commit 9096e9f into master Jul 7, 2023
@andresgomezfrr andresgomezfrr deleted the support-more-flyte-inputs branch July 7, 2023 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants