refactor: enhance MCP method callbacks with improved type safety and … #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error handling Those changes affect the Prompt and Resources Method callback implementations only - Add abstract methods `validateParamType` and `assignExchangeType` for better parameter handling - Implement strict type validation for exchange parameters (Sync vs Async vs Transport Context) - Replace custom exceptions (`McpPromptMethodException`, `McpResourceMethodException`) with standardized `McpError` - Add comprehensive parameter type validation with detailed error messages - Enhance exchange type assignment logic with proper type checking - Update all concrete implementations (Sync, Async, Stateless variants) for both prompt and resource callbacks - Add test coverage for new validation logic and error scenarios Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
tzolov
added a commit
that referenced
this pull request
Sep 22, 2025
…error handling (#59) Those changes affect the Prompt and Resources Method callback implementations only - Add abstract methods `validateParamType` and `assignExchangeType` for better parameter handling - Implement strict type validation for exchange parameters (Sync vs Async vs Transport Context) - Replace custom exceptions (`McpPromptMethodException`, `McpResourceMethodException`) with standardized `McpError` - Add comprehensive parameter type validation with detailed error messages - Enhance exchange type assignment logic with proper type checking - Update all concrete implementations (Sync, Async, Stateless variants) for both prompt and resource callbacks - Add test coverage for new validation logic and error scenarios Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…error handling
Those changes affect the Prompt and Resources Method callback implementations only
validateParamTypeandassignExchangeTypefor better parameter handlingMcpPromptMethodException,McpResourceMethodException) with standardizedMcpError