(2.3.x): Upgrading spring boot to 3.3.1 #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albertoimpl
changed the title
kvmw
approved these changes
Jul 8, 2024
Albertoimpl
force-pushed
the
arios/boot-33x
branch
from
56e814e to
9730409
Compare
spikymonkey
approved these changes
Jul 9, 2024
| assertThat(serviceInstanceState.getDescription()).isEqualTo("bar"); | ||
| assertThat(serviceInstanceState.getLastUpdated()) | ||
| .isEqualToIgnoringSeconds(new Date()); | ||
| .isCloseTo(new Date(), 1000L); |
There was a problem hiding this comment.
isCloseTo is definitely the right choice here, but are we sure 1 sec is enough to avoid flakes?
There was a problem hiding this comment.
I tested every method locally with @RepeatedTest(10000) and nothing failed.
Just did it again with 100.000 repetitions and they were all still happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.