Should RateLimitingSampler be public?

[elefeint]

I am trying to replicate* changes from SamplerAutoConfiguration autoconfiguration logic into spring-cloud-gcp, but RateLimitingSampler is package-private. Was it meant to be only package private, or is it okay to relax its visibility to public? ProbabilityBasedSampler, which is in the same package and is used similarly, is public already.

* I'd rather not replicate them at all and just rely on SamplerAutoConfiguration, but whenever TraceAutoConfiguration and SamplerAutoConfiguration are both present, TraceAutoConfiguration's NEVER_SAMPLE sampler gets instantiated due to Spring Boot ordering (TraceAutoConfiguration has an order and SamplerAutoConfiguration does not, so SamplerAutoConfiguration is processed at the end). From the docs, NEVER_SAMPLE seems like intended behavior.

[TYsewyn]

AFAIC that's actually a bug. SamplerAutoConfiguration should have @AutoConfigureBefore(TraceAutoConfiguration.class) and a way to enable/disable sampling with a property. Because spring-cloud-gcp is depending on spring-cloud-sleuth-core you'd have those samplers too.

I don't see the reason of replicating those changes into spring-cloud-gcp though.
What would be the added benefit of doing that?

[elefeint]

No added benefit whatsoever! @AutoConfigureBefore(TraceAutoConfiguration.class) in SamplerAutoConfiguration will be the perfect solution to our problem; then I can remove the custom sampler beans from StackdriverTraceAutoConfiguration for good.

[TYsewyn]

I've added it to my pile of todo items, will try to get it fixed in core.
In the meantime a simple @Import({ SamplerAutoConfiguration.class }) on StackdriverTraceAutoConfiguration should be able to do the trick.

[elefeint]

Thank you!
I tried the import route before, but because TraceAutoConfiguration is also brought in (through spring.factories in real world scenarios, and directly in tests), its NEVER_SAMPLE bean still took precedence.