Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in Webflux test when explicitely providing tracing headers #1507

Closed
beltram opened this issue Dec 14, 2019 · 0 comments
Closed

Regression in Webflux test when explicitely providing tracing headers #1507

beltram opened this issue Dec 14, 2019 · 0 comments
Labels
Projects
Milestone

Comments

@beltram
Copy link

beltram commented Dec 14, 2019

Describe the bug
Re-opening spring-projects/spring-framework#24191
Excerpt: in a junit test targeting a WebFlux controller, after migrating to spring-test 5.2.2.RELEASE, a new Span is created by TraceWebFilter regardless the ones provided in the WebTestClient by propagation headers because Reactor's context lacks original Span.

Root cause of the issue is spring-projects/spring-framework#23936.
Happens in Sleuth 2.2.0.RELEASE. Discriminant is spring-test version : works with 5.2.1.RELEASE and fails with 5.2.2.RELEASE

Sample
Reproducer is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Hoxton.SR3
  
Done
Development

No branches or pull requests

3 participants