Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamBridge's dynamic destinations should be closed on shutdown. #2835

Conversation

kurthong
Copy link
Contributor

  • if not, we might lose some messages on shutdown especially in case of kafka async mode producing.

- if not, we might lose some messages on shutdown especially in case of kafka async mode producing.
@olegz olegz added this to the 4.1.0-RC1 milestone Oct 20, 2023
@olegz olegz closed this in 6af3206 Oct 20, 2023
olegz pushed a commit that referenced this pull request Oct 20, 2023
- if not, we might lose some messages on shutdown especially in case of kafka async mode producing.

Resolves #2835
@kurthong kurthong deleted the dynamic-destinations-should-be-closed-on-shutdown branch October 20, 2023 14:35
@kurthong
Copy link
Contributor Author

kurthong commented Nov 1, 2023

@olegz, Would you mind to explain why this PR was just closed, not merged?
Github badges is somewhat important to me:-)

@sobychacko
Copy link
Contributor

@kurthong This PR is merged upstream in main and back-ported to 4.0.x. Do you see this as not merged? Please explain.

@kurthong
Copy link
Contributor Author

kurthong commented Nov 1, 2023

@kurthong This PR is merged upstream in main and back-ported to 4.0.x. Do you see this as not merged? Please explain.

@sobychacko
So, it was not intentional. Considering the history of this pull request, it was closed with unmerged commits. Later, Olegz pushed a commit that referenced this pull request.

Therefore, the pull request itself is image and not image.
However the commit itself is image.

And contributors would be proud of that their PRs are merged into one of their favorite projects:-)
image

I hope you understand.

@sobychacko
Copy link
Contributor

I don't follow what the issue is. I see your commit from this PR in the main commit history. https://github.com/spring-cloud/spring-cloud-stream/commits/main

@kurthong
Copy link
Contributor Author

kurthong commented Nov 1, 2023

@sobychacko
Yes, I'm aware that my commit has been merged into your repository. And I'm proud of that:-)
Maybe Olegz is using GitHub differently. Normally, 'Closed' means that the PR was not accepted.
image

If you still don't understand what I mean, please let it go. It's not that big deal.

@kurthong kurthong restored the dynamic-destinations-should-be-closed-on-shutdown branch August 23, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants