-
Notifications
You must be signed in to change notification settings - Fork 33
Guide update #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Guide update #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Java class with a main method class is required to build the application with CI. Additionally, the Initial folder is meant to mirror the content that is donwloaded from Spring Initializr, which comes with a main method class.
This commit implements Spring Boot Docker Compose Support to run the externaly Redis container. This simplifies the learning experince and makes the guide more repeatable.
The new content will walk the user through 4 different ways to build the application. First through a standalone jar file, next through a docker container, next through a native compile, and finally through a native container.
Lombok was initially used to reduce boilerplate code before Record functionality was introduced in Java. Now that we have records, we can switch out Lombok for Java records and still have no boilerplate code in the Coffee class. In general, the fewer dependencies that we have the more the learner can focus on the core teaching.
chemicL
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a brief look I think the changes are a great refresh.
Buzzardo
suggested changes
Jul 8, 2024
|
||
== Preparing to Build the Application | ||
|
||
To run the code without Spring Boot Docker Compose support, you need a version of Redis running locally to connect to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove to connect to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the guide in a few main areas:
The teaching content remains unchanged.