OpenAI ChatClient tools support #299
Closed
+1,405
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzolov
force-pushed
the
openai-tools-support
branch
from
fb3e0f5 to
144fa5d
Compare
tzolov
force-pushed
the
openai-tools-support
branch
from
144fa5d to
5e521f0
Compare
markpollack
reviewed
Feb 12, 2024
| @@ -35,4 +38,12 @@ public interface ChatOptions extends ModelOptions { | |||
|
|
|||
| void setTopK(Integer topK); | |||
|
|
|||
| default List<ToolFunctionCallback> getToolCallbacks() { | |||
| throw new UnsupportedOperationException("ToolCallbacks is not supported by this model"); | |||
There was a problem hiding this comment.
I think we should not have this default method, since the methods here should apply to every model.
markpollack
reviewed
Feb 12, 2024
| throw new UnsupportedOperationException("ToolCallbacks is not supported by this model"); | ||
| } | ||
|
|
||
| default void setToolCallbacks(List<ToolFunctionCallback> toolCallbacks) { |
markpollack
reviewed
Feb 12, 2024
| @@ -82,4 +82,9 @@ public ChatResponseMetadata getMetadata() { | |||
| return this.chatResponseMetadata; | |||
| } | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
There was a problem hiding this comment.
added equals and hashcode on merge.
|
removed the default methods in the chat option interface to make tests pass. Merged as ffd8222 Can review the small comments in this PR afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ChatClient function calling.
ToolFunctionCallbackandAbstractToolFunctionCallbackabstractions for defining and registering function callbacks with the ChatClient.